feat: add HttpRequestBody.contentLength() (#173)

lithic-com · Mar 13, 2024 · 21d5a9e · 21d5a9e
1 parent 2158ad3
commit 21d5a9e
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 2 deletions.
diff --git a/lithic-kotlin-client-okhttp/src/main/kotlin/com/lithic/api/client/okhttp/OkHttpClient.kt b/lithic-kotlin-client-okhttp/src/main/kotlin/com/lithic/api/client/okhttp/OkHttpClient.kt
@@ -105,12 +105,17 @@ private constructor(private val okHttpClient: okhttp3.OkHttpClient, private val
 
     private fun HttpRequestBody.toRequestBody(): RequestBody {
         val mediaType = contentType()?.toMediaType()
+        val length = contentLength()
 
         return object : RequestBody() {
             override fun contentType(): MediaType? {
                 return mediaType
             }
 
+            override fun contentLength(): Long {
+                return length
+            }
+
             override fun isOneShot(): Boolean {
                 return !repeatable()
             }

diff --git a/lithic-kotlin-core/src/main/kotlin/com/lithic/api/core/http/HttpRequestBody.kt b/lithic-kotlin-core/src/main/kotlin/com/lithic/api/core/http/HttpRequestBody.kt
@@ -10,6 +10,8 @@ interface HttpRequestBody : Closeable {
 
     fun contentType(): String?
 
+    fun contentLength(): Long
+
     /**
      * Determines if a request can be repeated in a meaningful way, for example before doing a
      * retry.

diff --git a/lithic-kotlin-core/src/main/kotlin/com/lithic/api/services/HttpRequestBodies.kt b/lithic-kotlin-core/src/main/kotlin/com/lithic/api/services/HttpRequestBodies.kt
@@ -5,6 +5,7 @@ package com.lithic.api.services
 import com.fasterxml.jackson.databind.json.JsonMapper
 import com.lithic.api.core.http.HttpRequestBody
 import com.lithic.api.errors.LithicException
+import java.io.ByteArrayOutputStream
 import java.io.OutputStream
 import org.apache.hc.client5.http.entity.mime.MultipartEntityBuilder
 
@@ -13,16 +14,31 @@ internal inline fun <reified T> json(
     value: T,
 ): HttpRequestBody {
     return object : HttpRequestBody {
-        override fun writeTo(outputStream: OutputStream) {
+        private var cachedBytes: ByteArray? = null
+
+        private fun serialize(): ByteArray {
+            if (cachedBytes != null) return cachedBytes!!
+
+            val buffer = ByteArrayOutputStream()
             try {
-                return jsonMapper.writeValue(outputStream, value)
+                jsonMapper.writeValue(buffer, value)
+                cachedBytes = buffer.toByteArray()
+                return cachedBytes!!
             } catch (e: Exception) {
                 throw LithicException("Error writing request", e)
             }
         }
 
+        override fun writeTo(outputStream: OutputStream) {
+            outputStream.write(serialize())
+        }
+
         override fun contentType(): String = "application/json"
 
+        override fun contentLength(): Long {
+            return serialize().size.toLong()
+        }
+
         override fun repeatable(): Boolean = true
 
         override fun close() {}
@@ -47,6 +63,8 @@ internal fun multipartFormData(
 
         override fun contentType(): String = entity.contentType
 
+        override fun contentLength(): Long = -1
+
         override fun repeatable(): Boolean = entity.isRepeatable
 
         override fun close() = entity.close()