Clean up Scrap_tests

Signed-off-by: nagesh bansal <[email protected]>

tests/controller_test/scrap_test.go

@@ -5,6 +5,7 @@ import (
 	"github.com/litmuschaos/chaos-exporter/controller"
 	"github.com/litmuschaos/chaos-exporter/controller/mocks"
 	v1alpha1 "github.com/litmuschaos/chaos-operator/api/litmuschaos/v1alpha1"
+	"github.com/stretchr/testify/require"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"testing"
 )
@@ -13,10 +14,6 @@ func TestGetLitmusChaosMetrics(t *testing.T) {
 	mockCtl := gomock.NewController(t)
 	defer mockCtl.Finish()
 	mockCollectData := mocks.NewMockResultCollector(mockCtl)
-
-	//FakeEngineName := "Fake Engine"
-	//FakeNamespace := "Fake Namespace"
-
 	tests := []struct {
 		name               string
 		execFunc           func()
@@ -53,6 +50,7 @@ func TestGetLitmusChaosMetrics(t *testing.T) {
 				},
 			},
 			monitoring: &controller.MonitoringEnabled{},
+			isErr:      false,
 		},
 	}
 	for _, tt := range tests {
@@ -66,9 +64,11 @@ func TestGetLitmusChaosMetrics(t *testing.T) {
 
 			r.GaugeMetrics.InitializeGaugeMetrics().RegisterFixedMetrics()
 			err := r.GetLitmusChaosMetrics(client, tt.overallChaosResult, tt.monitoring)
-			if !tt.isErr && err != nil {
-				t.Fatalf("test Failed as not able to get the Chaos result list")
+			if tt.isErr {
+				require.Error(t, err)
+				return
 			}
+			require.NoError(t, err)
 		})
 	}