Fix consider appKind when filtering target pods #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelMorrisEst
requested review from
ispeakc0de,
ksatchit and
uditgaurav
as code owners
MichaelMorrisEst
force-pushed
the
issue-679
branch
from
21d9a7c
to
b9e8a54
Compare
Signed-off-by: MichaelMorris <[email protected]>
MichaelMorrisEst
force-pushed
the
issue-679
branch
from
b9e8a54
to
e4069d8
Compare
ispeakc0de
reviewed
Jan 17, 2024
Signed-off-by: MichaelMorris <[email protected]>
|
Hi @ispeakc0de |
neelanjan00
approved these changes
Feb 29, 2024
ispeakc0de
approved these changes
Feb 29, 2024
SarthakJain26
approved these changes
Mar 1, 2024
Saranya-jena
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The App Kind specified by the user shall be taken into consideration when identifying target pods for the experiment so the experiment is carried out on pods that are consistent with the users inputs
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Fixes #679
Special notes for your reviewer:
Checklist:
breaking-changestagrequires-upgradetag