feat: Add a k6-loadgen chaos fault #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 8, 2024 22:57
Signed-off-by: namkyu1999 <[email protected]>
Signed-off-by: namkyu1999 <[email protected]>
namkyu1999
requested review from
ispeakc0de,
ksatchit and
uditgaurav
as code owners
neelanjan00
requested changes
Feb 15, 2024
Comment on lines
130
to
132
| HostPath: &corev1.HostPathVolumeSource{ | ||
| Path: experimentsDetails.ScriptPath, | ||
| }, |
There was a problem hiding this comment.
If an end user, who is executing the fault, doesn't have access to the host file system, they won't be able to create the script there and thus execute the fault. Therefore, we should use a ConfigMap to store the script and mount it here. The name of the ConfigMap can be an experiment input (we can have a default name).
There was a problem hiding this comment.
I changed this implement so that the script file is mounted in the helper pod using a secret name while taking the name of the secret as an experiment ENV input of go-runner.
Signed-off-by: namkyu1999 <[email protected]>
neelanjan00
approved these changes
Feb 15, 2024
neelanjan00
reviewed
Feb 15, 2024
Signed-off-by: namkyu1999 <[email protected]>
uditgaurav
reviewed
Mar 7, 2024
| return common.HelperFailedError(err, appLabel, experimentsDetails.ChaosNamespace, true) | ||
| } | ||
|
|
||
| //Deleting all the helper pod for container-kill chaos |
There was a problem hiding this comment.
Suggested change
| //Deleting all the helper pod for container-kill chaos | |
| //Deleting all the helper pod for k6-loadgen chaos |
| VolumeMounts: []corev1.VolumeMount{ | ||
| { | ||
| Name: volumeName, | ||
| MountPath: "/mnt", |
There was a problem hiding this comment.
we can use the constant defined above
uditgaurav
approved these changes
Mar 7, 2024
This was referenced Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I have implemented the k6-loadgen chaos fault in this PR based on the proposal.
reference: locust-loadgen
demo chaos hub
-- Repository URL: https://github.com/namkyu1999/chaos-charts
-- Hub Repository Branch: test
-- category: Load
result
dashboard
Which issue this PR fixes : fixes #4309
Special notes for your reviewer: @uditgaurav
Checklist:
breaking-changestagrequires-upgradetag