Include error message from stderr if container-kill fails (#740) #741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Should the container-kill experiment fail with an error, the error message is not logged and it is not included included in the fault summary of the experiment run. This would happen if the command used to kill the container returns an exit code other than 0. It makes it hard to troubleshoot container-kill, if it isn't working as intended.
The problem is that text added to the error the description is taken from the stdout of the command rather than stderr.
To fix this I have used the common.RunCLICommand function to execute the command. This will use the output from stderr to be included the error message instead of stdout.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #740Special notes for your reviewer:
Checklist:
breaking-changes
tagrequires-upgrade
tag