Remove hardcoded version of chaoscenter in pre-hook job in litmus-agent chart #329 #330
Conversation
- Use a variable for the version value in the hook-pre-install-job templates - Add variable to the values.yaml with a default value of 3.0.0-beta8 - Bump chart to version 0.2.1 Signed-off-by: Calvin Audier <[email protected]>
Signed-off-by: Calvin Audier <[email protected]>
Calvinaud
requested review from
ksatchit,
Jasstkn,
ajeshbaby,
gdsoumya,
imrajdas and
ispeakc0de
as code owners
Signed-off-by: Calvin Audier <[email protected]>
There was a problem hiding this comment.
The main reason to probably hardcode the version was to keep it compatible with the version of the chaos center. There might be other changes needed to the chart/code to work with a different version of the chaos center as things are changing quite rapidly. This modification gives users the impression that this particular chart can work with a different version too which might not be the case.
Tagging @Jonsy13 to confirm if this change is safe to make
|
Not sure either, but the hardcoded version mean we cannot deploy in 2.14.0 which is still at the moment the no beta version. In our deployment, we are working with all images in 2.14.0 and we updated the version manually in the agent configmap, will keep updated if we found any issues. |
Hey. Any update here? For me this change makes sense as long as default is stays the same. |
The agent helm chart is only supported for 3.x litmus version not 2.x, litmus doesn't provide any support for 2.x in this helm chart. Ref: https://github.com/litmuschaos/litmus-helm#install-external-agent |
|
Even if the version 2.x is not supported shouldn't the version still not be hardcoded to have the possible to overwrite it to have the risk of hardcoded incompatibility between chaoscenter and litmus agent (even between two 3.x version) ?
Should I add an extra comment for this variable to say "Change at your own risk" (and add it in the description of the variable) ? |
|
@Calvinaud I think the current approach is to have a separate version of the litmus agent that works for a specific 3.x version of chaos center so if you are using a specific version you need to use the specific chart version corresponding to that. |
|
I think it should be fine to have version to be provided via |
Just a random idea: |
|
Any opinion on my last comment ? |
Signed-off-by: Calvinaud <[email protected]>
|
Hello, |
I don't have a strong opinion about that. |
Does this mean 3.0.0-beta8 is the appropriate version for 3.2.0? |
|
Hello, @gdsoumya are you still requesting changes in this PR ? |
What this PR does / why we need it:
The version of the chaoscenter was hardcoded in the template of the litmus-agent charts that was posing problem when deploying with different version of chaoscenter. The version is now a variable.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]