-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add probe source part to kubernetes cmd properties of ChaosEngine manifest #4881
base: master
Are you sure you want to change the base?
Add probe source part to kubernetes cmd properties of ChaosEngine manifest #4881
Conversation
The backend-checks pipeline step have indicated a problem with imports order in file |
@namkyu1999 I have updated the fix branch with the master branch. Could you approve the workflow to run the pipeline? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @rogeriofbrito can you resolve the conflicts and check the DCO? |
933a71f
to
83d915d
Compare
83d915d
to
d7890aa
Compare
…ifest Signed-off-by: Rogério Brito <[email protected]>
@Saranya-jena Hi, I placed all changes of this MR in a new single commit and force the push. In this new commit I have fixed all issues related with DCO and conflicts with master branch. In this screen recording is shown the probe with source part being evaluated in edge mode in a pod-delete experiment. |
Proposed changes
Fixes the evaluation probe issue that occurs when source mode is enabled (probe executing inside a container). More details can be found in bellow referenced issue.
Fix: #4693
Probe executing in a k6 container after fix:
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: