Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add probe source part to kubernetes cmd properties of ChaosEngine manifest #4881

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rogeriofbrito
Copy link

@rogeriofbrito rogeriofbrito commented Sep 13, 2024

Proposed changes

Fixes the evaluation probe issue that occurs when source mode is enabled (probe executing inside a container). More details can be found in bellow referenced issue.
Fix: #4693

Probe executing in a k6 container after fix:
Screenshot 2024-09-12 at 16 52 08

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

@rogeriofbrito
Copy link
Author

The backend-checks pipeline step have indicated a problem with imports order in file ./chaoscenter/upgrade-agents/control-plane/versions/v0.0.0/manager.go, but this file wasn't modificated in this PR. How to proced in this case?

@rogeriofbrito
Copy link
Author

@namkyu1999 I have updated the fix branch with the master branch. Could you approve the workflow to run the pipeline?

@amityt amityt requested review from S-ayanide and Saranya-jena and removed request for S-ayanide September 30, 2024 04:52
Copy link
Member

@S-ayanide S-ayanide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resilience Probe evaluation fail when source is configured
2 participants