-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted an extended operation type to a root type in the GraphQL schema #4894
Converted an extended operation type to a root type in the GraphQL schema #4894
Conversation
…hema Signed-off-by: Suyeon Jung <[email protected]>
@suyeon-jung-dev can you please confirm if you have tried running the gqlgen command and it's running fine? |
I refactored root types to Query and Mutation in I've attached the gqlgen generate results below. |
…os_experiment.graphqls for gqlgen compatibility Signed-off-by: Suyeon Jung <[email protected]>
2ca2a95
to
2335ae4
Compare
I added And graphql server works well. I attached some logs from graphql server below.
|
Signed-off-by: Suyeon Jung <[email protected]>
Awesome thanks for confirming! 🚀 |
…hema (litmuschaos#4894) * Converted an extended operation type to a root type in the GraphQL schema Signed-off-by: Suyeon Jung <[email protected]> * Refactored GraphQL schema to use Query and Mutation root types in chaos_experiment.graphqls for gqlgen compatibility Signed-off-by: Suyeon Jung <[email protected]> * Update github.com/99designs/gqlgen version 0.17.42 to 0.17.49 Signed-off-by: Suyeon Jung <[email protected]> --------- Signed-off-by: Suyeon Jung <[email protected]> Co-authored-by: Namkyu Park <[email protected]> Signed-off-by: dusdjhyeon <[email protected]>
…hema (litmuschaos#4894) * Converted an extended operation type to a root type in the GraphQL schema Signed-off-by: Suyeon Jung <[email protected]> * Refactored GraphQL schema to use Query and Mutation root types in chaos_experiment.graphqls for gqlgen compatibility Signed-off-by: Suyeon Jung <[email protected]> * Update github.com/99designs/gqlgen version 0.17.42 to 0.17.49 Signed-off-by: Suyeon Jung <[email protected]> --------- Signed-off-by: Suyeon Jung <[email protected]> Co-authored-by: Namkyu Park <[email protected]> Signed-off-by: sagnik3788 <[email protected]>
Proposed changes
I converted an extended operation type to a root type in the GraphQL schema for the following 3 reasons:
According to the GraphQL specification, a schema must define the root operation types for each kind of operation it supports: queries, mutations, and subscriptions. This implies that there must be a clear starting point for executing any operation in the schema.
I believe this change will ensure that our schema adheres to the GraphQL specifications, potentially improving compatibility and maintainability.
Resolve #4893
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: