-
Notifications
You must be signed in to change notification settings - Fork 14
Add steps for accepting an invitation #23
Add steps for accepting an invitation #23
Conversation
Hey @neelanjan00 @Jonsy13 |
@mehabhalodiya while I am reviewing the PR, can you please fix the DCO check? It is failing because you haven't signed your git commits. Follow the steps here to fix it. From next time you can sign all your commits. |
Signed-off-by: mehabhalodiya <[email protected]>
a0c04a8
to
a696748
Compare
Is this fine @neelanjan00 ? |
LGTM, please resolve both of my comments. |
@uditgaurav can we merge this PR? |
Signed-off-by: mehabhalodiya <[email protected]>
f8ace64
to
0a1106d
Compare
But still second task is left! |
The second task is a common error across all the tutorials, we still are figuring out what would be the best approach for resolving it. |
@Jonsy13 PTAL! |
Just a quick note. Contributions shouldn't be made directly to the code files because they're autogenerated. The tutorial documentation uses a tool called Google codelabs. It allows us to write the documentation in either markdown or on Google docs with some special formatting. The .md file or docs is then used to easily autogenerate the HTML static files using a CLI tool called claat (Short for codelabs command line tool). This ensures that the tutorials have a single source of truth and aids collaborative effort in the writing without the need to write code. The docs where this tutorial is maintained can be found here. Thanks for the contribution @mehabhalodiya. Just felt this was important to note. I should probably write a contribution guide so other contributors don't make the same mistake. |
Signed-off-by: mehabhalodiya [email protected]
Resolves a task of :
Preview