Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

Add steps for accepting an invitation #23

Merged
merged 2 commits into from
Nov 14, 2021

Conversation

mehabhalodiya
Copy link
Contributor

@mehabhalodiya mehabhalodiya commented Nov 11, 2021

Signed-off-by: mehabhalodiya [email protected]

Resolves a task of :

Preview
lc1

@mehabhalodiya
Copy link
Contributor Author

mehabhalodiya commented Nov 11, 2021

Hey @neelanjan00 @Jonsy13
Can you PTAL?

@neelanjan00
Copy link
Member

neelanjan00 commented Nov 11, 2021

@mehabhalodiya while I am reviewing the PR, can you please fix the DCO check? It is failing because you haven't signed your git commits. Follow the steps here to fix it. From next time you can sign all your commits.

@mehabhalodiya
Copy link
Contributor Author

lc2

Is this fine @neelanjan00 ?

@neelanjan00
Copy link
Member

LGTM, please resolve both of my comments.

@neelanjan00
Copy link
Member

@uditgaurav can we merge this PR?

Signed-off-by: mehabhalodiya <[email protected]>
@mehabhalodiya
Copy link
Contributor Author

But still second task is left!
What to do in that?

@neelanjan00
Copy link
Member

The second task is a common error across all the tutorials, we still are figuring out what would be the best approach for resolving it.

@mehabhalodiya
Copy link
Contributor Author

@Jonsy13 PTAL!
Thank you.

@uditgaurav uditgaurav merged commit badfa2c into litmuschaos:master Nov 14, 2021
@Gbahdeyboh
Copy link
Contributor

Just a quick note.

Contributions shouldn't be made directly to the code files because they're autogenerated. The tutorial documentation uses a tool called Google codelabs. It allows us to write the documentation in either markdown or on Google docs with some special formatting. The .md file or docs is then used to easily autogenerate the HTML static files using a CLI tool called claat (Short for codelabs command line tool).

This ensures that the tutorials have a single source of truth and aids collaborative effort in the writing without the need to write code.

The docs where this tutorial is maintained can be found here.

Thanks for the contribution @mehabhalodiya.

Just felt this was important to note. I should probably write a contribution guide so other contributors don't make the same mistake.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants