refactor(ui): only initialize the api-client once #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazimAr
force-pushed
the
singleton
branch
2 times, most recently
from
3b69047 to
9a79fa6
Compare
bryson-g
approved these changes
Dec 12, 2024
| accessToken: string; | ||
| } | null = null; | ||
|
|
||
| private constructor() {} |
There was a problem hiding this comment.
usage syntax could be neater by calling getInstance inside the constructor and returning the instance, so you can use the singleton with the new ExampleClass() syntax.
i suppose it is just preference though
There was a problem hiding this comment.
Thats a good point you brought up. Can you push those changes to the PR and ill merge.
There was a problem hiding this comment.
@HazimAr Actually TypeScript class constructors can't return promises so nvm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jhosep-marin this will fix the multiple requests you were seeing on the api logs