fix(dashboard): better json view for TaskRun
#1112
Conversation
| } else if (variable.str) { | ||
| try { | ||
| const json = JSON.parse(variable.str) | ||
| return JSON.stringify(json, null, 4) | ||
| } catch { | ||
| return variable[key] | ||
| } |
There was a problem hiding this comment.
What about variable.jsonObj and variable.jsonArr?
That's a good point, this same function is being used across the dashboard. So please verify every use and check if the new behavior fit on every case. |
Yeah I think we should see what it looks like on all the JSON parsing as it might be better as a default. I'm sure there are other sections of the dashboard that have JSON that needs to be formatted. 🤷♂️ We don't know if all the JSON needs special rendering, in that case we should have it as the default. |
| } else if (variable.str) { | ||
| try { | ||
| const json = JSON.parse(variable.str) | ||
| return JSON.stringify(json, null, 4) | ||
| } catch { | ||
| return variable[key] | ||
| } |
Mijaíl 👋, I'm curious about your thought processes behind this. Is there any instance where you think we shouldn't display formatted JSON to the user? Do you think formatted JSON would bug some functionality in some way? I understand this variable util function has a lot of references, so it is hard to predict exactly how it interacts with everything, but let me know what you're thinking. |
resolves #1066
Before:
After: