feat(dashboard): varName of TaskDef in WfSpec

[hazimoarafa]

Before:

After:

[hazimoarafa]

This is not the correct implementation of getting the taskDef name. This uses the TaskNode instead of the TaskDef to get the variable name. Needs to be fixed

[hazimoarafa]

Works now.

The only issue is that it makes a call for every TaskDef needed, there is no straightforward way to fetch the TaskDef only when the tooltip is open. We can either keep this PR open or merge this and open an issue to refactor for performance.

There is caching enabled so it wont re-fetch on re-render but that's not enough

[mijailr]

The only issue is that it makes a call for every TaskDef needed, there is no straightforward way to fetch the TaskDef only when the tooltip is open. We can either keep this PR open or merge this and open an issue to refactor for performance.

You can prevent this by using the selected boolean available at the node, so you make the call only when selected === true

[hazimoarafa]

The only issue is that it makes a call for every TaskDef needed, there is no straightforward way to fetch the TaskDef only when the tooltip is open. We can either keep this PR open or merge this and open an issue to refactor for performance.

You can prevent this by using the selected boolean available at the node, so you make the call only when selected === true

Good thinking, I have implemented that.