Fix errors #4
Open
Fix errors #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Also, are you interested in co-maintain this crate? |
|
That would be great, thanks! |
Invitation sent. Also, do you have an account on https://crates.io/? |
|
Yes, with github account |
Invitation sent on crates.io |
|
Okay, now you can merge this PR yourself if you want |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev-dependencies, too. Fix a issue that the package fails to build when dependent crate doesn't inlucdeasync_std.xd3_streamandxd3_sourceto the heap.std::io::Resultinstead ofOptionon error case. I think we should define custom error later, but I think it's better to return IO error than just returningNone.