New color for process on supervision tree rendering #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The color from a worker was hard to distinguish from the color of a supervisor for some people.
hugobarauna
changed the title
josevalim
approved these changes
Jun 4, 2024
jonatanklosko
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The color of a worker was hard to distinguish from the color of a supervisor for some people (myself, for example).
Maybe it's hard for me to distinguish between them because I have a low level of color blindness.
Before
After
I came up with the new color value by asking ChatGPT for a color that would be colorblind-friendly, given we would maintain the color of a supervisor in the graph.