Update docs on nested Kino.start_child/1 #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatanklosko
commented
Jul 3, 2024
Comment on lines
-219
to
-220
| > frame = Kino.Frame.new() | ||
| > {:ok, assign(ctx, frame: frame)} |
There was a problem hiding this comment.
This example is confusing, we create a frame in Kino.JS.Live, but there is no obvious way how we would use that frame (since Kino.JS.Live itself is already about managing JS rendering). If we want a frame to render updates into, as we do in the dbg pipeline, it is actually more natural to create the frame upfront and pass as an argument.
I think it's more about creating kinos like Kino.DataTable.new() and rendering into a provided frame, and it's also more about GenServer, because it's a rare case for Kino.JS.Live.
josevalim
reviewed
Jul 3, 2024
josevalim
approved these changes
Jul 3, 2024
Co-authored-by: José Valim <[email protected]>
hugobarauna
reviewed
Jul 3, 2024
| > that you cannot use functions such as `Kino.DataTable.new/1` in | ||
| > `c:GenServer.init/1`. If you need to do that, you must either | ||
| > create the kinos beforehand and pass in the `GenServer` argument, | ||
| > or create them in `c:GenServer.handle_continue/2`. |
There was a problem hiding this comment.
Ohhh, didn't know it was possible to do that inside handle_continue ! 💡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐈