Add Kino.JS.Live events support to subscribe/unsubscribe #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR extends the Kino.Control subscription functionality to support Kino.JS.Live events, enabling users to subscribe to and unsubscribe from custom interactive components. This enhancement allows for building interactive custom forms and components that can communicate events back to the Elixir process.
- Updated
subscribe/2andunsubscribe/1functions to acceptKino.JS.Live.t()structs - Modified function documentation to reflect the new JS.Live events support
- Added comprehensive test coverage for the new Kino.JS.Live subscription functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/kino/control.ex | Extended subscribe/unsubscribe functions to support Kino.JS.Live structs and updated documentation |
| test/kino/control_test.exs | Added test case verifying subscription to Kino.JS.Live events works correctly |
jonatanklosko
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be useful, for example, for using custom kino in "custom form", like this one: https://gist.github.com/hugobarauna/0150a90009f737e6949c9285f34329de
So users could build something like this:
Here's the code for this example: https://gist.github.com/hugobarauna/a8adeb29d67ee7dda54da8f75a82274f