Allow users to assign folders to their apps #3088
Merged
+533
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleDsz
changed the title
josevalim
reviewed
Nov 3, 2025
josevalim
reviewed
Nov 3, 2025
| Use folders to organize how how apps are displayed. | ||
| ''' | ||
| } | ||
| /> |
There was a problem hiding this comment.
What happens if there are no folders? We have two options:
- Don't show anything (so we don't need to check
@teams_enabled) - Show something saying they can create folders in the Livebook Teams interface (requires
@teams_enabledchecks)
cc @hugobarauna
There was a problem hiding this comment.
Good question. I guess we can we can go with option 2:
Show something saying they can create folders in the Livebook Teams interface (requires @teams_enabled checks)
So that the folders feature gets discoverable from the Livebook side as well.
@josevalim what do you think?
There was a problem hiding this comment.
What happens if there are no folders?
You can deploy without selecting an app folder, which will be in the Ungrouped apps "folder"
There was a problem hiding this comment.
@hugobarauna i am fine either way. whatever you think is a better experience.
josevalim
reviewed
Nov 3, 2025
jonatanklosko
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.