fix: tighten VideoTrackRenderer Widget #695
Conversation
|
tests fail due to required changes in flutter-webrtc and webrtc-interface not being merged yet |
|
I just realized that I should probably move the sized box up the chain to |
|
This PR will be merged after the new flutter-webrtc is released |
|
I tested this PR and found that it broke the fit setting in VideoTrackRenderer. when I publish a video track from the portrait viewfinder on a mobile Original code 
RTCVideoViewObjectFitCover Modification from this PR RTCVideoViewObjectFitContain RTCVideoViewObjectFitCover As shown in the screenshot, PR broke the centering of widgets and the rendering of the RTCVideoViewObjectFitCover mode |
|
oh right, I didn't test with the cover option. All my sizing should be ignored in cover option as the widget will fill up all available space anyway. I'll push a fix soon |
This allows external users to e.g. apply rounded edges. Without this patch, VideoTrackRenderer will expand to its available space with no way for parent widgets to know how large the video actually is
also, cover all paths by moving up sizing logic to build function
holzgeist
force-pushed
the
video-size-constraint
branch
from
18c5f03 to
32b8b0a
Compare
This allows external users to e.g. apply rounded edges. Without this patch, VideoTrackRenderer will expand to its available space with no way (known to me..) for parent widgets to know how large the video actually is.
depends on flutter-webrtc/flutter-webrtc#1754 (and flutter-webrtc/webrtc-interface#30)