fix: remove FOREGROUND_SERVICE_MEDIA_PROJECTION permission from lib (#…

…172) * fix: remove FOREGROUND_SERVICE_MEDIA_PROJECTION permission from default lib * docs: update android screenshare readme
livekit · Aug 21, 2024 · 793ae2e · 793ae2e
1 parent 303732f
commit 793ae2e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -295,7 +295,12 @@ Enabling screenshare requires extra installation steps:
 
 Android screenshare requires a foreground service with type `mediaProjection` to be present.
 
-From version 2.4.0 onwards, this is handled internally and no extra setup is required.
+From version 2.4.0 onwards, the foreground service is handled internally, 
+but you must declare the permission yourself in your app's AndroidManifest.xml file.
+
+```
+<uses-permission android:name="android.permission.FOREGROUND_SERVICE_MEDIA_PROJECTION" />
+```
 
 ### iOS
 

diff --git a/android/src/main/AndroidManifest.xml b/android/src/main/AndroidManifest.xml
@@ -11,5 +11,4 @@
     <uses-permission android:name="android.permission.BLUETOOTH" />
     <uses-permission android:name="android.permission.BLUETOOTH_ADMIN" />
     <uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
-    <uses-permission android:name="android.permission.FOREGROUND_SERVICE_MEDIA_PROJECTION" />
 </manifest>
diff --git a/example/android/app/src/main/AndroidManifest.xml b/example/android/app/src/main/AndroidManifest.xml
@@ -12,6 +12,7 @@
     <uses-permission android:name="android.permission.FOREGROUND_SERVICE_CAMERA" />
     <uses-permission android:name="android.permission.FOREGROUND_SERVICE_MICROPHONE" />
     <uses-permission android:name="android.permission.FOREGROUND_SERVICE_MEDIA_PLAYBACK" />
+    <uses-permission android:name="android.permission.FOREGROUND_SERVICE_MEDIA_PROJECTION" />
     <application
       android:name=".MainApplication"
       android:label="@string/app_name"