Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail analyze on deprecation warnings #13

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

bcherry
Copy link
Contributor

@bcherry bcherry commented Jan 25, 2025

for some reason the default behavior of flutter analyze is to treat "info" warnings as fatal, even though the default behavior of dart analyze is not. it's too restrictive for info-level warnings to be fatal to CI, as deprecation notices go here and there are legitimate reasons to keep deprecated APIs to support older versions of Flutter.

To test this change, I reverted #8

@bcherry bcherry requested a review from cloudwebrtc January 25, 2025 01:12
@bcherry bcherry mentioned this pull request Jan 25, 2025
@cloudwebrtc cloudwebrtc merged commit eeb4505 into main Feb 5, 2025
8 checks passed
@cloudwebrtc cloudwebrtc deleted the bcherry/flutter-analyze branch February 5, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants