Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add trackmuted to roomcontext listener #16

Merged
merged 2 commits into from
Feb 6, 2025
Merged

add trackmuted to roomcontext listener #16

merged 2 commits into from
Feb 6, 2025

Conversation

bcherry
Copy link
Contributor

@bcherry bcherry commented Feb 5, 2025

The default behavior of setMicrophoneEnabled(false) is to simply mute it, which wasn't triggering RoomContext updates on the isMicrophoneEnabled property.

I also removed the muted listener in the visualizer, which didn't work because TrackMutedEvent is fired on Room and Participant and not on Track. It was also unnecessary, livekit/client-sdk-flutter#701 is a simpler solution for the issue.

@bcherry bcherry requested a review from cloudwebrtc February 5, 2025 18:58
@bcherry bcherry merged commit 2d53037 into main Feb 6, 2025
8 checks passed
@bcherry bcherry deleted the bcherry/on-muted branch February 6, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants