Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtc: bump ffi to v0.10.2 #271

Merged
merged 11 commits into from
Sep 20, 2024
Merged

rtc: bump ffi to v0.10.2 #271

merged 11 commits into from
Sep 20, 2024

Conversation

nbsp
Copy link
Member

@nbsp nbsp commented Sep 18, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: b66e488

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@livekit/rtc-node Patch
@livekit/rtc-node-darwin-arm64 Patch
@livekit/rtc-node-darwin-x64 Patch
@livekit/rtc-node-linux-arm64-gnu Patch
@livekit/rtc-node-linux-x64-gnu Patch
@livekit/rtc-node-win32-x64-msvc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

theomonnom
theomonnom approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@theomonnom theomonnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, can you add the new parameters inside the AudioSource. (buffer_size_ms)
There is also:
wait_for_playout
clear_queue

@nbsp
Copy link
Member Author

nbsp commented Sep 18, 2024

@theomonnom can you re-check? want to make sure i did this impl correctly

@nbsp nbsp merged commit c6766b8 into main Sep 20, 2024
8 checks passed
@nbsp nbsp deleted the nbsp/bump/ffi-v0.10.2 branch September 20, 2024 06:37
@github-actions github-actions bot mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theomonnom theomonnom theomonnom approved these changes

@davidzhao davidzhao davidzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbsp @davidzhao @theomonnom