make AudioStream use AsyncIterableIterator #272
+33
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8667110 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nbsp
force-pushed
the
nbsp/audiostream/iterator
branch
2 times, most recently
from
513dbff
to
aadbf24
Compare
An error occurred while trying to automatically change base from
nbsp/bump/ffi-v0.10.2
to
main
September 20, 2024 06:37
instead of having a typed EventEmitter
nbsp
force-pushed
the
nbsp/audiostream/iterator
branch
from
0daf003
to
8667110
Compare
lukasIO
reviewed
Sep 20, 2024
| return { done: true, value: undefined }; | ||
| } | ||
| } | ||
| return new Promise((resolve) => (this.queueResolve = resolve)); |
There was a problem hiding this comment.
hm. I think this.queueResolve might get overridden before being called?
so the async iterator could get stuck
There was a problem hiding this comment.
the Mutex helper that Théo has mentioned already might make sense here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of having a typed EventEmitter