feat: enable fully external configuration #386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the worker to be fully configured to use external containers only, in which case the worker no longer needs active container management.
This is primarily useful when using a fully containerised setup using e.g. docker compose, where the
ai-runner
containers for various pipelines/models are isolated containers.In such case, the need for access to the Docker daemon from the
ai-worker
, would prevent this setup from running because by default the host's docker daemon isn't available for other containers.While for a hybrid setup (seems uncommon), the docker socket still has to be passed as a volume or docker has to be ran as a root, having the availability for a fully containerized setup would be highly beneficial.
go-livepeer
This PR allows flexibility to how this feature can be implemented in go-livepeer, some options include
Explicitly define aiRunnerImage as "" as startup flag or something like "external"
From aiModels.json , check if all entries contain a valid URL parameter, if so, no need to start the runner container
Currently the second option is implemented in this draft PR : livepeer/go-livepeer#3335