Add Docker build #1323
Merged
Add Docker build #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leszko
commented
Jul 18, 2024
leszko
commented
Jul 18, 2024
Dockerfile
Outdated
| curl \ | ||
| ca-certificates \ | ||
| musl \ | ||
| python3 \ |
There was a problem hiding this comment.
Not sure we need all these dependencies. I guess it's for VOD. @thomshutt @mjh1 could you confirm we need those for vod?
There was a problem hiding this comment.
I'm not sure - other than ca-certificates we might be able to get rid of some of those others. It'll probably need a bit of trial and error though unfortunately
There was a problem hiding this comment.
Ok, I removed most of them (including ffmpeg), because I think we'll run VOD nodes still as the whole Catalyst bundle. And for the livestream API, we don't need it.
|
@hjpotter92 also I see the build failed because the Docker Hub registry does not exist. How to create it? |
hjpotter92
approved these changes
Jul 19, 2024
thomshutt
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We plan to enable running catalyst-api separately to catalyst, therefore it needs its own Docker image.
Note that it I didn't include
w3tool, because Web3 Storage has shut down, so we should remove the support for Web3 Storage.Design Doc: https://www.notion.so/livepeer/Zero-Impact-Catalyst-API-Deployments-c2b15232f3a2450ba3e4803130ecd2be?pvs=4#5ce68dfca1c341bfb6b21361d36d19df