Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to /analytics/log errors #1337

Merged
merged 1 commit into from
Jul 23, 2024
+2 −0
Merged

Add logging to /analytics/log errors #1337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions handlers/analytics.go
View file
Original file line number Diff line number Diff line change
@@ -108,6 +108,7 @@ func (c *AnalyticsHandlersCollection) Log() httprouter.Handle {
return func(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
log, err := parseAnalyticsLog(r, schema)
if log == nil {
glog.Warningf("error parsing analytics log request payload, err=%v", err)
cerrors.WriteHTTPBadRequest(w, "Invalid request payload", err)
return
}
@@ -127,6 +128,7 @@ func (c *AnalyticsHandlersCollection) Log() httprouter.Handle {
case dataCh <- ad:
// process data async
default:
glog.Warningf("error processing analytics log, too many requests")
cerrors.WriteHTTPInternalServerError(w, "error processing analytics log, too many requests", nil)
}
}