Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to remove local catabalancer state #1390

Merged
merged 6 commits into from
Jan 14, 2025
Merged

Refactor to remove local catabalancer state #1390

merged 6 commits into from
Jan 14, 2025

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Jan 13, 2025

Now that we're using a DB for the node stats we can remove the internal state for this data. The only state we still maintain in catabalancer is the list of nodes updated by serf.

@mjh1 mjh1 requested a review from leszko January 13, 2025 21:25
@mjh1 mjh1 requested a review from leszko January 14, 2025 13:29
@mjh1
Copy link
Contributor Author

mjh1 commented Jan 14, 2025

Had to make a small change not to use the serf member updates, catalyst-api doesn't receive those, we can rely on the DB data instead and exclude nodes where the data is stale.

@mjh1 mjh1 merged commit 0f48fac into main Jan 14, 2025
11 checks passed
@mjh1 mjh1 deleted the mh/catabalanc branch January 14, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants