Add timeout for node metric sending #1399
Merged
+52
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metrics/metrics.go
Outdated
| }), | ||
| CatabalancerSendDBDurationSec: promauto.NewHistogramVec(prometheus.HistogramOpts{ | ||
| Name: "catabalancer_send_db_duration", | ||
| Help: "Time taken to send catabalancer node metric updates to DB", |
There was a problem hiding this comment.
This one is for sending metric update to DB.
What is catabalancer_send_metric_duration about? It includes the time for pulling the metrics from mist, right?
I'm not sure if I understand the difference reading the Help: message
There was a problem hiding this comment.
That's right so we have a better idea of where any slowness lies, I'll update the help text
pwilczynskiclearcode
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In prod I saw stale metrics being ignored so we need to check the durations of the send operation and add an appropriate timeout.