Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Bump Livekit SDK version" #1814

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Revert "Bump Livekit SDK version" #1814

merged 1 commit into from
Jul 25, 2023

Conversation

thomshutt
Copy link
Contributor

Reverts #1813

This seems to be causing problems because of the following error:

Error: Cannot find module '/snapshot/app/node_modules/livekit-server-sdk/node_modules/axios/dist/node/axios.cjs'
1) If you want to compile the package/file into executable, please pay attention to compilation warnings and specify a literal in 'require' call. 2) If you don't want to compile the package/file into executable and want to 'require' it from filesystem (likely plugin), specify an absolute path in 'require' call using process.cwd() or process.execPath.
    at createEsmNotFoundErr (node:internal/modules/cjs/loader:967:15)
    at finalizeEsmResolution (node:internal/modules/cjs/loader:960:15)
    at resolveExports (node:internal/modules/cjs/loader:488:14)
    at Function.Module._findPath (node:internal/modules/cjs/loader:528:31)
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:932:27)
    at Function._resolveFilename (pkg/prelude/bootstrap.js:1951:46)
    at Function.Module._load (node:internal/modules/cjs/loader:787:27)
    at Module.require (node:internal/modules/cjs/loader:1012:19)
    at Module.require (pkg/prelude/bootstrap.js:1851:31)
    at require (node:internal/modules/cjs/helpers:102:18)

@thomshutt thomshutt requested a review from a team as a code owner July 25, 2023 11:30
@vercel
Copy link

vercel bot commented Jul 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
livepeer-studio 🔄 Building (Inspect) Jul 25, 2023 11:30am

@thomshutt thomshutt enabled auto-merge (squash) July 25, 2023 11:30
gioelecerati
gioelecerati approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@gioelecerati gioelecerati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomshutt thomshutt merged commit 3e30f59 into master Jul 25, 2023
7 of 8 checks passed
@thomshutt thomshutt deleted the revert-1813-bump-livekit-sdk branch July 25, 2023 11:32
thomshutt added a commit that referenced this pull request Jul 25, 2023
@thomshutt
Revert "Bump Livekit SDK version (#1813)" (#1814)
8a04fc2 
This reverts commit 9ba6acb.
iameli added a commit that referenced this pull request Jul 25, 2023
@iameli
Revert "Revert "Bump Livekit SDK version (#1813)" (#1814)"
9e0ad48 
This reverts commit 3e30f59.
iameli added a commit that referenced this pull request Jul 25, 2023
@iameli
Revert "Revert "Bump Livekit SDK version (#1813)" (#1814)"
a0d2ab6 
This reverts commit 3e30f59.
iameli added a commit that referenced this pull request Jul 25, 2023
@iameli
bump livekit, figure out axios problems (#1815)
14298fe 
* Revert "Revert "Bump Livekit SDK version (#1813)" (#1814)"

This reverts commit 3e30f59.

* api: make sure executable is runnable in Docker

* api: manually add livekit-server-sdk to pkg inclusions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gioelecerati gioelecerati gioelecerati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomshutt @gioelecerati