Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump livekit, figure out axios problems #1815

Merged
merged 3 commits into from
Jul 25, 2023
Merged

bump livekit, figure out axios problems #1815

merged 3 commits into from
Jul 25, 2023

Conversation

iameli
Copy link
Contributor

@iameli iameli commented Jul 25, 2023

  • Bumps livekit.
  • Adds a failing test for when it doesn't work in the Docker build

@iameli iameli requested a review from a team as a code owner July 25, 2023 17:56
@vercel
Copy link

vercel bot commented Jul 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 9:42pm

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tho not sure what is different here that fixed the livekit+axios stuff. Was it only the image problem in livepeer-infra after all?

@victorges
Copy link
Member

Ah cool, got it, it didn't get fixed yet 🤔

#18 [stage-1 4/4] RUN /usr/local/bin/livepeer-api --help
#18 3.834 Error: Cannot find module '/snapshot/app/node_modules/livekit-server-sdk/node_modules/axios/dist/node/axios.cjs'
#18 3.834 1) If you want to compile the package/file into executable, please pay attention to compilation warnings and specify a literal in 'require' call. 2) If you don't want to compile the package/file into executable and want to 'require' it from filesystem (likely plugin), specify an absolute path in 'require' call using process.cwd() or process.execPath.
#18 3.834     at createEsmNotFoundErr (node:internal/modules/cjs/loader:967:15)
#18 3.834     at finalizeEsmResolution (node:internal/modules/cjs/loader:960:15)
#18 3.834     at resolveExports (node:internal/modules/cjs/loader:488:14)
#18 3.834     at Function.Module._findPath (node:internal/modules/cjs/loader:528:31)
#18 3.834     at Function.Module._resolveFilename (node:internal/modules/cjs/loader:932:27)
#18 3.834     at Function._resolveFilename (pkg/prelude/bootstrap.js:1951:46)
#18 3.834     at Function.Module._load (node:internal/modules/cjs/loader:787:27)
#18 3.834     at Module.require (node:internal/modules/cjs/loader:1012:19)
#18 3.834     at Module.require (pkg/prelude/bootstrap.js:1851:31)
#18 3.834     at require (node:internal/modules/cjs/helpers:102:18)
#18 ERROR: process "/bin/sh -c /usr/local/bin/livepeer-api --help" did not complete successfully: exit code: 1

@iameli
Copy link
Contributor Author

iameli commented Jul 25, 2023

@victorges Yeah, I think this fixes f57e8ee

@victorges
Copy link
Member

@iameli cool! 🚀

@iameli iameli merged commit 14298fe into master Jul 25, 2023
10 checks passed
@iameli iameli deleted the eli/livekit-bump branch July 25, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants