stream-info-service: Avoid creating indexes and reduce pool size #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Realized that every stream-info-service is trying to create all the DB tables and indexes on startup. Theoretically they return quickly as they already exist, but it still means we open up to 10 connections from each instance everytime a broadcaster pod starts (or the stream-info restarts). This is hopefully what's been causing connection issues with Postgres just now.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
emranemran
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Realized that every stream-info-service is trying to create all the DB tables and indexes on startup. Theoretically they return quickly as they already exist, but it still means we open up to 10 connections from each instance everytime a broadcaster pod starts (or the stream-info restarts).
This is hopefully what's been causing connection issues with Postgres just now.
Specific updates (required)
true/10on main app)dbclientHow did you test each of these updates (required)
Config change only that reduces load and reuses already tested code in production on main app.
Will just test on staging and send to prod at a safe time.
Does this pull request close any open issues?
Related to PS-842
Checklist