feat(interactive-bridge): add interactive player controls support #25
Conversation
…Stalled listeners.
There was a problem hiding this comment.
A lot of things to do here. Some of which depends on the point you raised about the scope of this ticket. I think when you're adding features you should also add tests or in this case testing support through the LiveryBridgeInteractive element and MockPlayerBridge class. E.g. at: https://interactive-bridge.liveryvideo.com/?mock. Or https://liv-2386.d184my9gzkn37n.amplifyapp.com/ which unfortunately is used by Nicholas' branch and this branch due to it's unconventional name (feature/LIV-2386) is not auto deployed.
Perhaps we should schedule a little meeting with you, me and Jeroen and/or Joep to discuss the scope?
…ith the missing methods.
… because the web player bridge extended class has to initialize the subscription due to this.player requirement
…-bridge into feature/LIV-2386
There was a problem hiding this comment.
I haven't completely reviewed this yet (mostly just looked at index, AbstractPlayerBridge, schema and a bit of InteractiveBridge), but since it's taking so long I figured perhaps we should just start with the change requests so far. Hopefully Tyler will also be able to similarly improve the other parts of this PR. Regardless after those improvements I will have to review this again anyhow so I could then also finish up reviewing the remaining parts.
…-bridge into feature/LIV-2386
|
I'll finish up the final changes here myself |
… superfluous exports And a few other tweaks.
# [1.11.0](v1.10.0...v1.11.0) (2024-02-05) ### Features * **interactive-bridge:** add interactive player controls support ([#25](#25)) ([f07e911](f07e911))
Closes: https://exmachina.atlassian.net/browse/LIV-2386