fix: change streamPhases type to array of tuples, use humanStringify #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Config streamPhases type change to enable validation of time values as numbers. And to facilitate working with it down the line in TypeScript. Use humanStringify() to support showing values like Infinity for getPlayback duration. Fix LiveryBridgeInteractive to enable selecting quality -1 for ABR. Have MockPlayerBridge return an error as expected when selecting an illegal quality index. And tweak some other things for testing purposes.
ci-liveryvideo
pushed a commit
that referenced
this pull request
Feb 9, 2024
## [1.11.3](v1.11.2...v1.11.3) (2024-02-09) ### Bug Fixes * change streamPhases type to array of tuples, use humanStringify ([#28](#28)) ([58c51fe](58c51fe))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config streamPhases type change to enable validation of time values as numbers.
And to facilitate working with it down the line in TypeScript.
Use humanStringify() to support showing values like Infinity for getPlayback duration.
Fix LiveryBridgeInteractive to enable selecting quality -1 for ABR.
Have MockPlayerBridge return an error as expected when selecting an illegal quality index.
And tweak some other things for testing purposes.
Ticket: https://exmachina.atlassian.net/browse/LIV-2387