maint: remove pytest-flake8

pytest-flake8 has been broken for over a year with flake8 >= 5.0
[1][2][3], and has not had any commits since March 2022.  Drop in
favor of simply invoking flake8 separately outside of pytest.  Ensure
that "make check" now invokes flake8.

[1] tholo/pytest-flake8#83
[2] tholo/pytest-flake8#87
[3] tholo/pytest-flake8#92

Signed-off-by: Daniel Harding <[email protected]>

.github/workflows/main.yml

@@ -49,8 +49,7 @@ jobs:
               pylint \
               python-is-python3 \
               python3-setuptools-scm \
-              python3-pytest \
-              python3-pytest-flake8
+              python3-pytest
           # Runtime dependencies (required)
           sudo apt-get install \
               python3-qtpy \

Makefile

@@ -277,11 +277,10 @@ check::
 	$(FLAKE8) $(FLAKE8_FLAGS) $(flags) $(file)
 	$(PYLINT) $(PYLINT_FLAGS) --output-format=colorized $(flags) $(file)
 else
-# NOTE: flake8 is not part of "make check" because the pytest-flake8 plugin runs flake8
-# checks during "make test" via pytest.
 check:: all
 check:: test
 check:: doc
+check:: flake8
 check:: pylint
 endif
 

pytest.ini

@@ -1,6 +1,6 @@
 [pytest]
 norecursedirs=dist build .tox .eggs env*
-addopts=--doctest-modules --flake8
+addopts=--doctest-modules
 doctest_optionflags=ALLOW_UNICODE ELLIPSIS
 filterwarnings=
     # https://github.com/pytest-dev/pytest/issues/6928

requirements/requirements-dev.txt

@@ -15,7 +15,6 @@ PyYAML
 ## mock and pytest packages are used by the "make test" test suite.
 pytest>=3.6
 pytest-cov
-pytest-flake8
 pytest-black-multipy
 
 ## Build and install documentation using "make doc" and "make install-doc".

setup.cfg

@@ -88,7 +88,6 @@ testing =
 	# upstream
 	pytest >= 3.5, !=3.7.3
 	pytest-checkdocs >= 1.2.3
-	pytest-flake8
 	pytest-black >= 0.3.7; \
 		# workaround for jaraco/skeleton#22
 		python_implementation != "PyPy"