fix: on highlightText dispatch a change event

livingdocsIO · Jun 28, 2024 · 240d82b · 240d82b
1 parent e4f86a4
commit 240d82b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/core.js b/src/core.js
@@ -382,7 +382,7 @@ export class Editable {
    */
   highlight ({editableHost, text, highlightId, textRange, raiseEvents, type = 'comment'}) {
     if (!textRange) {
-      return highlightSupport.highlightText(editableHost, text, highlightId, type)
+      return highlightSupport.highlightText(editableHost, text, highlightId, type, raiseEvents ? this.dispatcher : undefined)
     }
     if (typeof textRange.start !== 'number' || typeof textRange.end !== 'number') {
       error(

diff --git a/src/highlight-support.js b/src/highlight-support.js
@@ -7,7 +7,7 @@ const highlightSupport = {
 
   // Used to highlight arbitrary text in an editable. All occurrences
   // will be highlighted.
-  highlightText (editableHost, text, highlightId, type) {
+  highlightText (editableHost, text, highlightId, type, dispatcher) {
     if (this.hasHighlight(editableHost, highlightId)) return
     const blockText = highlightText.extractText(editableHost)
 
@@ -19,6 +19,7 @@ const highlightSupport = {
     if (matches && matches.length) {
       if (highlightId) matches[0].id = highlightId
       highlightText.highlightMatches(editableHost, matches)
+      if (dispatcher) dispatcher.notify('change', editableHost)
       return matches[0].startIndex
     }
   },