Merge pull request phpmyadmin#19343 from kamil-tekiela/mysqlDie

Add type hint to mysqlDie

src/Controllers/Import/ImportController.php

@@ -641,8 +641,6 @@ public function __invoke(ServerRequest $request): Response
                         false,
                         $_SESSION['Import_message']['go_back_url'],
                     );
-
-                    return $this->response->response();
                 }
 
                 if (Current::$table != $tableFromSql && $tableFromSql !== '') {

src/Controllers/Table/GetFieldController.php

@@ -81,8 +81,6 @@ public function __invoke(ServerRequest $request): Response
                 __('MySQL returned an empty result set (i.e. zero rows).'),
                 $sql,
             );
-
-            return $this->response->response();
         }
 
         $result ??= '';

src/DatabaseInterface.php

@@ -180,10 +180,7 @@ public function query(
         $result = $this->tryQuery($query, $connectionType, $options, $cacheAffectedRows);
 
         if (! $result) {
-            // The following statement will exit
             Generator::mysqlDie($this->getError($connectionType), $query);
-
-            ResponseRenderer::getInstance()->callExit();
         }
 
         return $result;

src/Html/Generator.php

@@ -679,6 +679,8 @@ public static function showDocumentationLink(
      * @param string $backUrl       URL for the "back" link (full path is not required).
      * @param bool   $exit          Whether execution should be stopped or the error message should be returned.
      *
+     * @psalm-return ($exit is true ? never : string|null)
+     *
      * @global string $table The current table.
      * @global string $db    The current database.
      */