Skip to content

Commit

Permalink
Add type hints instead of mixed (phpmyadmin#18976)
Browse files Browse the repository at this point in the history
* Remove some empty() statements

Signed-off-by: Kamil Tekiela <[email protected]>

* Fix docbloc

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type hint to getHtmlForOneKey()

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to buildColumnCreationStatement()

Signed-off-by: Kamil Tekiela <[email protected]>

* Add return type to fetchByMode()

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to getCompatibilities()

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to getDirContent

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to getCharLists()

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to executeSqlQuery()

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to findLineNumberAndColumn

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to lint()

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to getHtmlForNewTables3NF()

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to getViewsAndCreateSqlViewStandIn()

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to getPossibleRowFormat()

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to getTableAltersArray()

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to getValuesForColumn()

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to getAvailableMimeTypes()

Signed-off-by: Kamil Tekiela <[email protected]>

* Add types to TwigLintCommand

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to isRowCountApproximated

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to getReplicationStatus()

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type in formatVariable()

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to fetchSingleRow()

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to getPages()

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to CentralColumns::getParams()

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to removeRelation()

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to getWarnings()

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to getTableCommentsArray()

Signed-off-by: Kamil Tekiela <[email protected]>

* Fix docbloc comment

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to sanitizeUrl()

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to uploadProgressSetup()

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to explodeMarkup()

Signed-off-by: Kamil Tekiela <[email protected]>

* Add types in Table

Signed-off-by: Kamil Tekiela <[email protected]>

* Add type to getHtmlForDataStatements()

Signed-off-by: Kamil Tekiela <[email protected]>

---------

Signed-off-by: Kamil Tekiela <[email protected]>
  • Loading branch information
kamil-tekiela authored Feb 7, 2024
1 parent 650d615 commit 79a68a4
Show file tree
Hide file tree
Showing 35 changed files with 152 additions and 455 deletions.
2 changes: 1 addition & 1 deletion examples/signon-script.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
function get_login_credentials(string $user): array
{
/* Optionally we can use passed username */
if (! empty($user)) {
if ($user !== '') {
return [$user, 'password'];
}

Expand Down
Loading

0 comments on commit 79a68a4

Please sign in to comment.