Skip to content

Commit

Permalink
fix(deps): update dependency eslint-plugin-promise to v6
Browse files Browse the repository at this point in the history
- fix(deps): update dependency eslint to v8.5.0
- now requires eslint 8.5.0 due to `prefer-object-has-own`
  • Loading branch information
ljosberinn authored Dec 18, 2021
1 parent e289a88 commit 5574f19
Show file tree
Hide file tree
Showing 11 changed files with 304 additions and 215 deletions.
1 change: 1 addition & 0 deletions integration/cra-js/eslint-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -731,6 +731,7 @@
"padded-blocks": 0,
"padding-line-between-statements": 0,
"prefer-exponentiation-operator": 1,
"prefer-object-has-own": 0,
"prefer-object-spread": 1,
"quote-props": 0,
"quotes": 0,
Expand Down
1 change: 1 addition & 0 deletions integration/cra-ts/eslint-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -883,6 +883,7 @@
"padded-blocks": 0,
"padding-line-between-statements": 0,
"prefer-exponentiation-operator": 1,
"prefer-object-has-own": 0,
"prefer-object-spread": 1,
"quote-props": 0,
"quotes": 0,
Expand Down
1 change: 1 addition & 0 deletions integration/next-js/eslint-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -622,6 +622,7 @@
"padded-blocks": 0,
"padding-line-between-statements": 0,
"prefer-exponentiation-operator": 1,
"prefer-object-has-own": 0,
"prefer-object-spread": 1,
"quote-props": 0,
"quotes": 0,
Expand Down
1 change: 1 addition & 0 deletions integration/next-ts/eslint-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -782,6 +782,7 @@
"padded-blocks": 0,
"padding-line-between-statements": 0,
"prefer-exponentiation-operator": 1,
"prefer-object-has-own": 0,
"prefer-object-spread": 1,
"quote-props": 0,
"quotes": 0,
Expand Down
1 change: 1 addition & 0 deletions integration/remix-js/eslint-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -607,6 +607,7 @@
"padded-blocks": 0,
"padding-line-between-statements": 0,
"prefer-exponentiation-operator": 1,
"prefer-object-has-own": 0,
"prefer-object-spread": 1,
"quote-props": 0,
"quotes": 0,
Expand Down
1 change: 1 addition & 0 deletions integration/remix-ts/eslint-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -760,6 +760,7 @@
"padded-blocks": 0,
"padding-line-between-statements": 0,
"prefer-exponentiation-operator": 1,
"prefer-object-has-own": 0,
"prefer-object-spread": 1,
"quote-props": 0,
"quotes": 0,
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
"eslint-plugin-jest-dom": "3.9.2",
"eslint-plugin-jest-formatting": "3.1.0",
"eslint-plugin-jsx-a11y": "6.5.1",
"eslint-plugin-promise": "5.2.0",
"eslint-plugin-promise": "6.0.0",
"eslint-plugin-react": "7.27.1",
"eslint-plugin-react-hooks": "4.3.0",
"eslint-plugin-sonarjs": "0.11.0",
Expand All @@ -101,15 +101,15 @@
"@semantic-release/changelog": "6.0.1",
"@semantic-release/git": "10.0.1",
"@types/jest": "27.0.3",
"eslint": "8.4.1",
"eslint": "8.5.0",
"jest": "27.4.5",
"jest-watch-typeahead": "0.6.5",
"prettier": "2.5.1",
"rimraf": "3.0.2",
"semantic-release": "18.0.1"
},
"peerDependencies": {
"eslint": ">=8.1.0"
"eslint": ">=8.5.0"
},
"engines": {
"node": ">=14.17"
Expand Down
7 changes: 7 additions & 0 deletions src/__tests__/__snapshots__/createConfig.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,7 @@ exports[`createConfig allows passing env 1`] = `
"prefer-exponentiation-operator": 1,
"prefer-named-capture-group": 0,
"prefer-numeric-literals": 1,
"prefer-object-has-own": 0,
"prefer-object-spread": 1,
"prefer-promise-reject-errors": 2,
"prefer-regex-literals": 2,
Expand Down Expand Up @@ -1259,6 +1260,7 @@ exports[`createConfig allows passing extra rules 1`] = `
"prefer-exponentiation-operator": 1,
"prefer-named-capture-group": 0,
"prefer-numeric-literals": 1,
"prefer-object-has-own": 0,
"prefer-object-spread": 1,
"prefer-promise-reject-errors": 2,
"prefer-regex-literals": 2,
Expand Down Expand Up @@ -1999,6 +2001,7 @@ exports[`createConfig allows passing overrides 1`] = `
"prefer-exponentiation-operator": 1,
"prefer-named-capture-group": 0,
"prefer-numeric-literals": 1,
"prefer-object-has-own": 0,
"prefer-object-spread": 1,
"prefer-promise-reject-errors": 2,
"prefer-regex-literals": 2,
Expand Down Expand Up @@ -2736,6 +2739,7 @@ exports[`createConfig allows passing parserOptions 1`] = `
"prefer-exponentiation-operator": 1,
"prefer-named-capture-group": 0,
"prefer-numeric-literals": 1,
"prefer-object-has-own": 0,
"prefer-object-spread": 1,
"prefer-promise-reject-errors": 2,
"prefer-regex-literals": 2,
Expand Down Expand Up @@ -3473,6 +3477,7 @@ exports[`createConfig allows passing plugins 1`] = `
"prefer-exponentiation-operator": 1,
"prefer-named-capture-group": 0,
"prefer-numeric-literals": 1,
"prefer-object-has-own": 0,
"prefer-object-spread": 1,
"prefer-promise-reject-errors": 2,
"prefer-regex-literals": 2,
Expand Down Expand Up @@ -4209,6 +4214,7 @@ exports[`createConfig matches snapshot 1`] = `
"prefer-exponentiation-operator": 1,
"prefer-named-capture-group": 0,
"prefer-numeric-literals": 1,
"prefer-object-has-own": 0,
"prefer-object-spread": 1,
"prefer-promise-reject-errors": 2,
"prefer-regex-literals": 2,
Expand Down Expand Up @@ -4965,6 +4971,7 @@ exports[`createConfig overrides applies incrementalAdoption as intended 1`] = `
"prefer-exponentiation-operator": 0,
"prefer-named-capture-group": 0,
"prefer-numeric-literals": 0,
"prefer-object-has-own": 0,
"prefer-object-spread": 0,
"prefer-promise-reject-errors": 1,
"prefer-regex-literals": 1,
Expand Down
5 changes: 5 additions & 0 deletions src/__tests__/rulesets/__snapshots__/eslint-core.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,7 @@ exports[`createEslintCoreRules allows passing custom rules 1`] = `
"prefer-exponentiation-operator": "warn",
"prefer-named-capture-group": "off",
"prefer-numeric-literals": "warn",
"prefer-object-has-own": "off",
"prefer-object-spread": "warn",
"prefer-promise-reject-errors": "error",
"prefer-regex-literals": "error",
Expand Down Expand Up @@ -708,6 +709,7 @@ exports[`createEslintCoreRules matches snapshot with ts & cra 1`] = `
"prefer-exponentiation-operator": "warn",
"prefer-named-capture-group": "off",
"prefer-numeric-literals": "warn",
"prefer-object-has-own": "off",
"prefer-object-spread": "warn",
"prefer-promise-reject-errors": "error",
"prefer-regex-literals": "error",
Expand Down Expand Up @@ -1080,6 +1082,7 @@ exports[`createEslintCoreRules matches snapshot with ts & next 1`] = `
"prefer-exponentiation-operator": "warn",
"prefer-named-capture-group": "off",
"prefer-numeric-literals": "warn",
"prefer-object-has-own": "off",
"prefer-object-spread": "warn",
"prefer-promise-reject-errors": "error",
"prefer-regex-literals": "error",
Expand Down Expand Up @@ -1452,6 +1455,7 @@ exports[`createEslintCoreRules matches snapshot with typescript 1`] = `
"prefer-exponentiation-operator": "warn",
"prefer-named-capture-group": "off",
"prefer-numeric-literals": "warn",
"prefer-object-has-own": "off",
"prefer-object-spread": "warn",
"prefer-promise-reject-errors": "error",
"prefer-regex-literals": "error",
Expand Down Expand Up @@ -1845,6 +1849,7 @@ exports[`createEslintCoreRules matches snapshot without typescript 1`] = `
"prefer-exponentiation-operator": "warn",
"prefer-named-capture-group": "off",
"prefer-numeric-literals": "warn",
"prefer-object-has-own": "off",
"prefer-object-spread": "warn",
"prefer-promise-reject-errors": "error",
"prefer-regex-literals": "error",
Expand Down
10 changes: 10 additions & 0 deletions src/rulesets/eslint-core.js
Original file line number Diff line number Diff line change
Expand Up @@ -1656,6 +1656,16 @@ const getStylisticIssuesRules = ({
*/
'prefer-exponentiation-operator': 'warn',

/**
* prefer Object.hasOwn over Object.prototype.hasOwnproperty.call()
*
* enable once https://github.com/sindresorhus/eslint-plugin-unicorn/issues/1644 is closed
* and remove `unicorn/prefer-object-has-own`
*
* @see https://eslint.org/docs/rules/prefer-object-has-own
*/
'prefer-object-has-own': 'off',

/**
* prefer spreading over Object.assign
*
Expand Down
Loading

0 comments on commit 5574f19

Please sign in to comment.