Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persisting last user selected Anr setting on connect #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joaocoelho2
Copy link

Proposed changes

Persisting last user selected anr setting (across disconnect/reconnect)

Why

Personally I really hate how bose qc35 always defaults to anr High setting every time I turn them on,
(and then you have to go into the phone app, bla bla bla). Most of the time I use mine with anr off.

What I did

I added 3 lines to your code so that the last setting that was selected when headphones were disconnected,
will be set again when reconnected.

This is an adaptation i made for my own personal use case,
I made this pull request in case you wanna add it back to yours aswell

Thank You

Thank you for making this, I've been looking for something like this for about 3 Years!

Cheers!

@ll0s0ll
Copy link
Owner

ll0s0ll commented Jul 14, 2021

Thank you for your contribution.
I'm using google translate, so I'm sorry if it's strange English.

It's a nice idea.
I always use it in the low setting.
Certainly, when I connected, I always switched to low.
I wonder why I couldn't think of automating it.

So, I added a function to memorize the last selected ANR mode.
Since I used UserDefaults, the app remembers it even when I quit the app.

I think this method suits more people,
so I wrote a new code, not what you requested for a pull.

https://github.com/ll0s0ll/NoQCNoLife/releases/tag/v1.1.0

Thank you.

@joaocoelho2
Copy link
Author

joaocoelho2 commented Jul 15, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants