Map-demo #49
Open
Map-demo #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated the map api with its key to allow the browser to render the google map, and also added some code changes to Map.html for fsname and some extra code lines to Map.js
added click event listener and setting the marker to null to remove the marker where user clicked on
sorting the airport list in ascending order
centering the map to the most recently marked ariport code, helping use to find the aiport easly
added new css attributes to get a new look for the map and list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates made to the code:
1)coded lines to display complete information about the airports
2)sorted the drop-down to make it easy for the users to find the codes
3)added marker remove functionality to remove marker by clicking on it
4) centered the airport marker every time user clicks a new airport code
5)adjusted the map and the info box next to each other to in order to use less window space and easily visible for the users.
interesting things you noticed about the code: I never worked on google maps API, I got a chance to do it with this project and I learned that the map API provides a lot of flexibility to the programmer to make any changes.
suggestions for improvements: I can see the UI layout is pretty basic it can be enhanced by using basic bootstrap classes and any framework or use of libraries will also help