Implemented core map features and additional features #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, here are my changes for the map-demo project.
I modified Map.html by adding a button for deleting the currently selected airport marker. I also changed the names of the divs inside the setting-value div because one of the previous names, "setting-name", conflicted with another div also called "setting-name". I also added the charset meta tag, Bootstrap styling, and changed the quote marks in the text to single quotes as I noticed they were originally double quotes which is grammatically incorrect.
I also modified Map.js to fill in the rest of the airport data, allow for deletion of airport markers, and sort the list of airports.
In addition to that, I added functionality to jump the map to a new tag when it's added, if it's outside the current viewing area of the map. This can help users locate their tags more easily. I also added code to prevent new tags from being created if an identical tag already exists.
For further improvements, I was thinking that perhaps there could be a check box to hide the "airport-settings" div and instead show an airport's data when the user hovers over its marker. I could implement this given more time.