Skip to content

Commit

Permalink
Merge pull request #17 from gaby/docker-fixes
Browse files Browse the repository at this point in the history
Dockerfile updates and Fixes to CI process
  • Loading branch information
lllllllillllllillll authored Nov 19, 2023
2 parents e1d1df0 + eceea4f commit 53ea6a8
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 12 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: CI/CD Docker Build/Publish
name: Docker

on:
push:
Expand All @@ -19,6 +19,7 @@ on:
jobs:
build-and-publish-image:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -55,12 +56,12 @@ jobs:
# Build image and only publish if not a Pull Request
- name: Build and Publish Docker Image
uses: docker/build-push-action@v5
timeout-minutes: 30
with:
context: .
push: ${{ github.event_name != 'pull_request' }}
target: release
cache-from: type=gha
cache-to: type=gha,mode=max
platforms: linux/amd64,linux/arm64,linux/arm/v7,linux/arm/v6
platforms: linux/amd64,linux/arm64
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
labels: ${{ steps.meta.outputs.labels }}
19 changes: 11 additions & 8 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,18 +1,22 @@
# syntax=docker/dockerfile:1

ARG NODE_VERSION=20.0.0

FROM node:${NODE_VERSION}-alpine
FROM node:20-alpine

# Use production node environment by default.
ENV NODE_ENV production

WORKDIR /app


# Download dependencies as a separate step to take advantage of Docker's caching.
# Leverage a cache mount to /root/.npm to speed up subsequent builds.
# Leverage a bind mounts to package.json and package-lock.json to avoid having to copy them into
# into this layer.
RUN --mount=type=bind,source=package.json,target=package.json \
    --mount=type=bind,source=package-lock.json,target=package-lock.json \
    --mount=type=cache,target=/root/.npm
--mount=type=bind,source=package-lock.json,target=package-lock.json \
--mount=type=cache,target=/root/.npm \
npm ci --omit=dev

# Run the application as a root user.
# Run the application as a non-root user.
USER root

# Copy the rest of the source files into the image.
Expand All @@ -23,4 +27,3 @@ EXPOSE 8000

# Run the application.
CMD node app.js

0 comments on commit 53ea6a8

Please sign in to comment.