Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/lib.rs: make this build on big-endian aarch64. #95

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

he32
Copy link
Contributor

@he32 he32 commented Oct 2, 2024

Do this by avoiding trying to use neon / SIMD on big-endian aarch64. Neon intrinsics are problematical on big-endian targets, ref. rust-lang/stdarch#1484

Do this by avoiding trying to use neon / SIMD on big-endian aarch64.
Neon intrinsics are problematical on big-endian targets, ref.
rust-lang/stdarch#1484
@llogiq
Copy link
Owner

llogiq commented Oct 3, 2024

Thank you!

@llogiq llogiq merged commit 240c02c into llogiq:master Oct 3, 2024
0 of 55 checks passed
@workingjubilee
Copy link

Please fix this by fixing the intrinsics upstream. Fixing this in every single crate is not less effort than fixing it in stdarch: rust-lang/stdarch#1484 (comment)

@he32
Copy link
Contributor Author

he32 commented Oct 7, 2024

Please fix this by fixing the intrinsics upstream. Fixing this in every single crate is not less effort than fixing it in stdarch: rust-lang/stdarch#1484 (comment)

Fixing the intrinsics upstream would of course be beneficial. However, I'll claim that if it was easy or little effort, that it would already be done, but that has not happened. If someone is waiting for me to fix that they are seriously over-estimating my abilities in this area. I currently appear unable to find the actual connecting tissue between library/stdarch/crates/core_arch/src/aarch64/neon/mod.rs and LLVM, and also to correlate that mod.rs with arm_neon.h from clang (which appears to be generated), and things are not lining up (names of operations don't match).

@workingjubilee
Copy link

Fixing the intrinsics upstream would of course be beneficial. However, I'll claim that if it was easy or little effort, that it would already be done, but that has not happened.

There are many things where it is fairly easy to do after a few minutes of focused effort, so I generally am skeptical of that notion. However you have taken a look, and provided feedback. That is good to know. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants