Memory leak in yajl_tree_parse #168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hstern
force-pushed
the
tree_parse_leak
branch
from
d74c806 to
1b9509d
Compare
|
Rebased against master |
ctx.stack was not being cleaned up after a parse error. this patch pops all remaining elements and frees them.
|
I can confirm that this memory leak still exists in YAJL, and that this fixes it. It would be nice to see this merged. |
|
This has been open for 3 months now and it's an easy fix. What's the hold up? |
|
Checking in. This has been open for 9 months now. |
|
1 year and 4 months now. Does @lloyd still exist? |
|
There's been lots of forks of this lib and still no @lloyd maybe it's time to find a maintainer and create an "official" fork. |
|
Hey @lloyd, you there? |
|
Hi, Lloyd, is there any chances to have this PR merged? |
robohack
added a commit
to robohack/yajl
that referenced
this pull request
Jul 17, 2023
- use wrapped malloc() et al wrappers consistently - update example/parse_config.c to do memory leak detection - add a regression test using example/parse_config Several issues in lloyd/yajl complained about this leak, and comments in lloyd/yajl#102 showed a mostly correct fix though none of these issues mentioned or actually fixed the directly related error reporting problem. Fixes lloyd/yajl#102, fixes lloyd/yajl#113, fixes lloyd/yajl#168, fixes lloyd/yajl#191, fixes lloyd/yajl#223, fixes lloyd/yajl#250. Also fixes lloy/yajl#185.
|
A long time ago, I have done a ticket: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The yajl_tree_parse function does not deallocate ctx.stack when yajl_complete_parse returns an error condition, resulting in a memory leak. The solution is to pop all elements off the stack and yajl_tree_free their values.