Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to doobie 1.0.0-RC5 #385

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Update to doobie 1.0.0-RC5 #385

merged 1 commit into from
Nov 23, 2023

Conversation

limansky
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8bd7a22) 85.71% compared to head (ff3cd33) 85.71%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #385   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files          63       63           
  Lines         511      511           
  Branches       34       34           
=======================================
  Hits          438      438           
  Misses         73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lloydmeta lloydmeta merged commit 46d051c into lloydmeta:master Nov 23, 2023
3 checks passed
@limansky limansky deleted the patch-2 branch November 30, 2023 16:25
@limansky
Copy link
Contributor Author

Hi @lloydmeta
Is there any chance to get it released? As I see RC4 and RC5 aren't binary compatible (at least sbt thinks it's so).

@lloydmeta
Copy link
Owner

Oof. Do things work if you simply exclude the dependency when adding the enumeratum-doobie lib as a dependency?

If that works, great. Otherwise I'm going to probably think twice about RC or M dependent versions of libs.

@kovacshuni
Copy link

Release please

@lloydmeta
Copy link
Owner

Release please

@kovacshuni does what I described in #385 (comment) work for you?

@limansky
Copy link
Contributor Author

@lloydmeta I suppose there is no guarantee what the RC4 and RC5 are fully binary compatible. So if it works for some case it doesn't proof that it will work for another.

@lloydmeta
Copy link
Owner

Fair enough, thanks @limansky . Just pushed to Maven Central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants