Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MooreToCore] Support to lower unpacked struct type #7565

Merged
merged 3 commits into from
Sep 4, 2024
Merged

[MooreToCore] Support to lower unpacked struct type #7565

merged 3 commits into from
Sep 4, 2024

Conversation

cepheus69
Copy link

@cepheus69 cepheus69 commented Aug 31, 2024 •
edited
Loading

This is a simple way to map unpackedStructType (Moore type) to structType in hw dialect directly.

@cepheus69
Copy link
Author

This pull request is an attempt to fix the problem: #7535

@mingzheTerapines
Copy link
Contributor

Glad to see this resolved

hailongSun2000
hailongSun2000 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@hailongSun2000 hailongSun2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this solution.

@hailongSun2000 hailongSun2000 merged commit c0a77be into llvm:main Sep 4, 2024
4 checks passed
@cepheus69 cepheus69 deleted the buyun/uarray_struct_type_conversion branch September 4, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hailongSun2000 hailongSun2000 hailongSun2000 approved these changes

@fabianschuiki fabianschuiki Awaiting requested review from fabianschuiki

@maerhart maerhart Awaiting requested review from maerhart

Assignees
No one assigned
Labels
Moore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cepheus69 @mingzheTerapines @hailongSun2000