[HW] Add pass to outline certain ops: hw-outline-ops #7991
Conversation
This pass outlines all hw::HWModuleOp operations into separate modules, uniquifying the modules. This is useful for debugging and cutting down RTL size for certain high level ops. Notes: - Does not support ops with regions. - In uniquifying the modules, dialect attributes are ignored. Only properties are observed. - Dialect attributes are, however, inherited by the module instances.
teqdruid
force-pushed
the
teqdruid/hw/outline
branch
from
34d67d3 to
9167f05
Compare
|
Tagging a few people as I don't know who's working this week. |
There was a problem hiding this comment.
Re. the region constriant: technically, it should be perfectly legal to outline operations with regions that are IsolatedFromAbove. I think this would be a great addition which would apply to e.g. the pipeline ops (which currently online has an inline lowering.
Regarding dialect attributes - i assume the reason why you didn't include this is because you can't generate a pretty (module) name for them. To expand capabilities, would it make sense to keep the existing name generation mechanism, but then additionally just hash the set of dialect/"other" attributes and append that to the module name?
If you opt not to do this, i think there should be some tests where the targeted ops have dialect attributes, to verify that everything works correctly.
In any case, this seems like a useful tool that may come in handy here or there when debugging RTL to force some more hierarchy into the trace.
|
|
||
| let options = [ | ||
| ListOption<"opNames", "op-names", "std::string", | ||
| "List of operation names to outline. If empty, this pass is a no-op."> |
There was a problem hiding this comment.
Just to foolproof this, show an example as well (to remove ambiguity about whether or not to include the dialect name (${dialect}.${opname}).
|
|
||
| // Append only the inherent attributes to the module name. | ||
| nameOS << "_attrs"; | ||
| if (auto regOp = op->getRegisteredInfo()) { |
There was a problem hiding this comment.
nit: A bit misleading to call this regOp - how about registeredOpName?
Problem with that is hashing and comparing regions would be expensive.
No. It's because dialect attributes like |
This pass outlines all of the selected operations into separate modules,
uniquifying the modules. This is useful for debugging and cutting down RTL
size for certain high level ops.
Notes:
properties are respected.