[CIR][CIRGen] Introduce cir.delete.array op #1172
Open
+63
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neat, the direction makes sense to me. You may also be interested in #1055 as a somewhat similar area where we want to design a high-level representation, btw – if there's something we could do there that would help your analysis, we'd love to hear about it. |
bcardosolopes
requested changes
Nov 27, 2024
|
|
||
| def DeleteArrayOp : CIR_Op<"delete.array">, | ||
| Arguments<(ins CIR_PointerType:$address)> { | ||
| let summary = "Delete address representing an array"; |
There was a problem hiding this comment.
Can you add an example as part of the description?
clang/lib/CIR/Dialect/Transforms/LoweringPrepareItaniumCXXABI.h
Outdated
Show resolved
Hide resolved
bcardosolopes
changed the title
ChuanqiXu9
force-pushed
the
introduce_delete_array
branch
from
e679d2c
to
38d4f20
Compare
ChuanqiXu9
force-pushed
the
introduce_delete_array
branch
from
38d4f20
to
5f47b83
Compare
| // We might be deleting a pointer to array. If so, GEP down to the | ||
| // first non-array element. | ||
| // (this assumes that A(*)[3][7] is converted to [3 x [7 x %A]]*) | ||
| // In CIRGen: we handle this differently because .... .. .. . . |
There was a problem hiding this comment.
Oh, the trailing dots were not literal haha, just a placeholder for you to mention what you need to mention :)
bcardosolopes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on a clangir based solution to improve C++'s safety (https://discourse.llvm.org/t/rfc-a-clangir-based-safe-c/83245). This is similar with the previous analysis only approach I proposed, where we may not care about the lowered code. And this is what I described as layering problems in https://discourse.llvm.org/t/rfc-a-clangir-based-safe-c/83245
This is similar with the other issue proposed #1128. We'd better to emit the higher level operations and lowering/optimizing it later.
This is also inspired our handling method for VAArg, where we use ABI information to lower things during the passes. It gives me more confidence that I am doing things right.