[CIR][CIRGen] Add more support for __cxa_rethrow #1343
Merged
+126
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part of PR#1290, adding initial support for
__cxa_rethrow
.So, the last PR did not support statements that come after the
UnreachableOp
from therethrow
, we just ignored them, e.g:This PR fixes this.
A few changes:
rethrow
statements split their block into multiple blocks.rethrow
were added and old ones were modified.Concern:
ScopeOp
workaround still exists which I guess was one of the main concerns when we tried in the last PR.As usual, I am open to discussions on this and how to approach it better -:)