[libc][math][c23] Enable _Float16 entrypoints on 32-bit Arm and on RISC-V #109700

overmighty · 2024-09-23T18:10:04Z

No description provided.

…SC-V

llvmbot · 2024-09-23T18:10:43Z

@llvm/pr-subscribers-libc

Author: OverMighty (overmighty)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/109700.diff

3 Files Affected:

(modified) libc/config/linux/arm/entrypoints.txt (+78)
(modified) libc/config/linux/riscv/entrypoints.txt (+90)
(modified) libc/include/llvm-libc-macros/float16-macros.h (-1)

diff --git a/libc/config/linux/arm/entrypoints.txt b/libc/config/linux/arm/entrypoints.txt
index 1be9a872dd2f7f..072e5d0b2ff1de 100644
--- a/libc/config/linux/arm/entrypoints.txt
+++ b/libc/config/linux/arm/entrypoints.txt
@@ -413,6 +413,84 @@ set(TARGET_LIBM_ENTRYPOINTS
     libc.src.math.ufromfpxl
 )
 
+if(LIBC_TYPES_HAS_FLOAT16)
+  list(APPEND TARGET_LIBM_ENTRYPOINTS
+    # math.h C23 _Float16 entrypoints
+    libc.src.math.canonicalizef16
+    libc.src.math.ceilf16
+    libc.src.math.copysignf16
+    libc.src.math.exp10f16
+    libc.src.math.exp2f16
+    libc.src.math.expf16
+    libc.src.math.expm1f16
+    libc.src.math.f16add
+    libc.src.math.f16addf
+    libc.src.math.f16addl
+    libc.src.math.f16div
+    libc.src.math.f16divf
+    libc.src.math.f16divl
+    libc.src.math.f16fma
+    libc.src.math.f16fmaf
+    libc.src.math.f16fmal
+    libc.src.math.f16mul
+    libc.src.math.f16mulf
+    libc.src.math.f16mull
+    libc.src.math.f16sqrt
+    libc.src.math.f16sqrtf
+    libc.src.math.f16sqrtl
+    libc.src.math.f16sub
+    libc.src.math.f16subf
+    libc.src.math.f16subl
+    libc.src.math.fabsf16
+    libc.src.math.fdimf16
+    libc.src.math.floorf16
+    libc.src.math.fmaxf16
+    libc.src.math.fmaximum_mag_numf16
+    libc.src.math.fmaximum_magf16
+    libc.src.math.fmaximum_numf16
+    libc.src.math.fmaximumf16
+    libc.src.math.fminf16
+    libc.src.math.fminimum_mag_numf16
+    libc.src.math.fminimum_magf16
+    libc.src.math.fminimum_numf16
+    libc.src.math.fminimumf16
+    libc.src.math.fmodf16
+    libc.src.math.frexpf16
+    libc.src.math.fromfpf16
+    libc.src.math.fromfpxf16
+    libc.src.math.getpayloadf16
+    libc.src.math.ilogbf16
+    libc.src.math.ldexpf16
+    libc.src.math.llogbf16
+    libc.src.math.llrintf16
+    libc.src.math.llroundf16
+    libc.src.math.logbf16
+    libc.src.math.lrintf16
+    libc.src.math.lroundf16
+    libc.src.math.modff16
+    libc.src.math.nanf16
+    libc.src.math.nearbyintf16
+    libc.src.math.nextafterf16
+    libc.src.math.nextdownf16
+    libc.src.math.nexttowardf16
+    libc.src.math.nextupf16
+    libc.src.math.remainderf16
+    libc.src.math.remquof16
+    libc.src.math.rintf16
+    libc.src.math.roundevenf16
+    libc.src.math.roundf16
+    libc.src.math.scalblnf16
+    libc.src.math.scalbnf16
+    libc.src.math.setpayloadf16
+    libc.src.math.setpayloadsigf16
+    libc.src.math.totalorderf16
+    libc.src.math.totalordermagf16
+    libc.src.math.truncf16
+    libc.src.math.ufromfpf16
+    libc.src.math.ufromfpxf16
+  )
+endif()
+
 set(TARGET_LLVMLIBC_ENTRYPOINTS
   ${TARGET_LIBC_ENTRYPOINTS}
   ${TARGET_LIBM_ENTRYPOINTS}
diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt
index ff3d821c664c5b..ed84d2894fe33d 100644
--- a/libc/config/linux/riscv/entrypoints.txt
+++ b/libc/config/linux/riscv/entrypoints.txt
@@ -590,6 +590,96 @@ set(TARGET_LIBM_ENTRYPOINTS
     libc.src.math.ufromfpxl
 )
 
+if(LIBC_TYPES_HAS_FLOAT16)
+  list(APPEND TARGET_LIBM_ENTRYPOINTS
+    # math.h C23 _Float16 entrypoints
+    libc.src.math.canonicalizef16
+    libc.src.math.ceilf16
+    libc.src.math.copysignf16
+    libc.src.math.exp10f16
+    libc.src.math.exp2f16
+    libc.src.math.expf16
+    libc.src.math.expm1f16
+    libc.src.math.f16add
+    libc.src.math.f16addf
+    libc.src.math.f16addl
+    libc.src.math.f16div
+    libc.src.math.f16divf
+    libc.src.math.f16divl
+    libc.src.math.f16fma
+    libc.src.math.f16fmaf
+    libc.src.math.f16fmal
+    libc.src.math.f16mul
+    libc.src.math.f16mulf
+    libc.src.math.f16mull
+    libc.src.math.f16sqrt
+    libc.src.math.f16sqrtf
+    libc.src.math.f16sqrtl
+    libc.src.math.f16sub
+    libc.src.math.f16subf
+    libc.src.math.f16subl
+    libc.src.math.fabsf16
+    libc.src.math.fdimf16
+    libc.src.math.floorf16
+    libc.src.math.fmaxf16
+    libc.src.math.fmaximum_mag_numf16
+    libc.src.math.fmaximum_magf16
+    libc.src.math.fmaximum_numf16
+    libc.src.math.fmaximumf16
+    libc.src.math.fminf16
+    libc.src.math.fminimum_mag_numf16
+    libc.src.math.fminimum_magf16
+    libc.src.math.fminimum_numf16
+    libc.src.math.fminimumf16
+    libc.src.math.fmodf16
+    libc.src.math.frexpf16
+    libc.src.math.fromfpf16
+    libc.src.math.fromfpxf16
+    libc.src.math.getpayloadf16
+    libc.src.math.ilogbf16
+    libc.src.math.ldexpf16
+    libc.src.math.llogbf16
+    libc.src.math.llrintf16
+    libc.src.math.llroundf16
+    libc.src.math.logbf16
+    libc.src.math.lrintf16
+    libc.src.math.lroundf16
+    libc.src.math.modff16
+    libc.src.math.nanf16
+    libc.src.math.nearbyintf16
+    libc.src.math.nextafterf16
+    libc.src.math.nextdownf16
+    libc.src.math.nexttowardf16
+    libc.src.math.nextupf16
+    libc.src.math.remainderf16
+    libc.src.math.remquof16
+    libc.src.math.rintf16
+    libc.src.math.roundevenf16
+    libc.src.math.roundf16
+    libc.src.math.scalblnf16
+    libc.src.math.scalbnf16
+    libc.src.math.setpayloadf16
+    libc.src.math.setpayloadsigf16
+    libc.src.math.totalorderf16
+    libc.src.math.totalordermagf16
+    libc.src.math.truncf16
+    libc.src.math.ufromfpf16
+    libc.src.math.ufromfpxf16
+  )
+
+  if(LIBC_TYPES_HAS_FLOAT128)
+    list(APPEND TARGET_LIBM_ENTRYPOINTS
+      # math.h C23 mixed _Float16 and _Float128 entrypoints
+      libc.src.math.f16addf128
+      libc.src.math.f16divf128
+      libc.src.math.f16fmaf128
+      libc.src.math.f16mulf128
+      libc.src.math.f16sqrtf128
+      libc.src.math.f16subf128
+    )
+  endif()
+endif()
+
 if(LIBC_TYPES_HAS_FLOAT128)
   list(APPEND TARGET_LIBM_ENTRYPOINTS
     # math.h C23 _Float128 entrypoints
diff --git a/libc/include/llvm-libc-macros/float16-macros.h b/libc/include/llvm-libc-macros/float16-macros.h
index 229e3e62f2aedf..dca0a44f50c6ac 100644
--- a/libc/include/llvm-libc-macros/float16-macros.h
+++ b/libc/include/llvm-libc-macros/float16-macros.h
@@ -13,7 +13,6 @@
 
 #if defined(__FLT16_MANT_DIG__) &&                                             \
     (!defined(__GNUC__) || __GNUC__ >= 13 || defined(__clang__)) &&            \
-    !defined(__arm__) && !defined(_M_ARM) && !defined(__riscv) &&              \
     !defined(_WIN32)
 #define LIBC_TYPES_HAS_FLOAT16

overmighty · 2024-09-23T18:11:55Z

Tested with libc-math-unittests target in Ubuntu 24.04 LTS armv7l and riscv64 containers with QEMU.

mikhailramalho · 2024-09-23T20:01:57Z

Tested with libc-math-unittests target in Ubuntu 24.04 LTS armv7l and riscv64 containers with QEMU.

The rv64 buildbots run ninja check-libc and there were some failures because of #107607, as clang fails to generate an fmv instruction; as of clang 19 no fix landed for the issue.

Can you run all the tests with fullbuild enabled for rv64? The last time I tried (a couple of weeks ago), this failed on my visionfive board (rv64).

overmighty · 2024-09-24T13:48:50Z

Only these unrelated tests failed with check-libc in fullbuild mode:

libc/test/src/sys/mman/linux/madvise_test.cpp
libc/test/src/sys/mman/linux/mincore_test.cpp
libc/test/src/sys/mman/linux/mlock_test.cpp
libc/test/src/sys/mman/linux/posix_madvise_test.cpp
libc/test/src/sys/prctl/linux/prctl_test.cpp
libc/test/src/sys/stat/chmod_test.cpp
libc/test/src/sys/stat/fchmod_test.cpp
libc/test/src/sys/stat/fchmodat_test.cpp
libc/test/src/termios/termios_test.cpp
libc/test/src/unistd/access_test.cpp
libc/test/src/unistd/pread_pwrite_test.cpp
libc/test/src/unistd/read_write_test.cpp

nickdesaulniers · 2024-09-27T16:33:23Z

libc/config/linux/riscv/entrypoints.txt

+
+  if(LIBC_TYPES_HAS_FLOAT128)
+    list(APPEND TARGET_LIBM_ENTRYPOINTS
+      # math.h C23 mixed _Float16 and _Float128 entrypoints


Are you going to add these for arm, too?

arm fp16 is facing some clang compiler problems as I remember.

Perhaps a comment w/ a TODO linking to the issue on file would be appropriate then.

_Float128 is not supported on 32-bit Arm.

Do they have sth similar to force-enable-int128

_Float128 is not supported on 32-bit Arm.

Filed ARM-software/abi-aa#287 for now.

Do they have sth similar to force-enable-int128

Clang doesn't have one, and GCC doesn't seem to either.

[libc][math][c23] Enable _Float16 entrypoints on 32-bit Arm and on RI…

2c58fd9

…SC-V

overmighty requested review from mikhailramalho and lntue September 23, 2024 18:10

llvmbot added the libc label Sep 23, 2024

nickdesaulniers reviewed Sep 27, 2024

View reviewed changes

overmighty mentioned this pull request Oct 7, 2024

[libc] Add sinpif16 function #110994

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[libc][math][c23] Enable _Float16 entrypoints on 32-bit Arm and on RISC-V #109700

[libc][math][c23] Enable _Float16 entrypoints on 32-bit Arm and on RISC-V #109700

overmighty commented Sep 23, 2024

llvmbot commented Sep 23, 2024

overmighty commented Sep 23, 2024

mikhailramalho commented Sep 23, 2024

overmighty commented Sep 24, 2024

nickdesaulniers Sep 27, 2024

SchrodingerZhu Sep 27, 2024

nickdesaulniers Sep 27, 2024

overmighty Sep 27, 2024

SchrodingerZhu Sep 27, 2024

nickdesaulniers Sep 27, 2024

overmighty Sep 27, 2024

[libc][math][c23] Enable _Float16 entrypoints on 32-bit Arm and on RISC-V #109700

Are you sure you want to change the base?

[libc][math][c23] Enable _Float16 entrypoints on 32-bit Arm and on RISC-V #109700

Conversation

overmighty commented Sep 23, 2024

llvmbot commented Sep 23, 2024

overmighty commented Sep 23, 2024

mikhailramalho commented Sep 23, 2024

overmighty commented Sep 24, 2024

nickdesaulniers Sep 27, 2024

Choose a reason for hiding this comment

SchrodingerZhu Sep 27, 2024

Choose a reason for hiding this comment

nickdesaulniers Sep 27, 2024

Choose a reason for hiding this comment

overmighty Sep 27, 2024

Choose a reason for hiding this comment

SchrodingerZhu Sep 27, 2024

Choose a reason for hiding this comment

nickdesaulniers Sep 27, 2024

Choose a reason for hiding this comment

overmighty Sep 27, 2024

Choose a reason for hiding this comment